Skip to content

Prevent planner from locking up on large problems. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luke-clifton wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent planner from locking up on large problems. #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
267ec9e
Prevent planner from locking up on large problems.
luke-clifton Mar 10, 2020
6b6f569
Protect against blocking on stderr filling up.
luke-clifton Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions FastDownward/Exec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,14 @@ module FastDownward.Exec
)
where

import Control.Concurrent.Async (concurrently)
import Control.Monad.IO.Class ( MonadIO, liftIO )
import Data.Char
import Data.List
import Data.Maybe
import Data.Ratio
import qualified Data.Text.Lazy
import qualified Data.Text
import qualified Data.Text.IO
import qualified Data.Text.Lazy.IO
import qualified FastDownward.SAS
import qualified FastDownward.SAS.Plan
Expand Down Expand Up @@ -294,16 +296,14 @@ callFastDownward Options{ fastDownward, problem, planFilePath, searchConfigurati
Data.Text.Lazy.IO.hPutStr writeProblemHandle ( FastDownward.SAS.Plan.toSAS problem )
>> hClose writeProblemHandle

(stderr, stdout) <- concurrently
(Data.Text.IO.hGetContents stderrHandle)
(Data.Text.IO.hGetContents stdoutHandle)

exitCode <-
waitForProcess processHandle

stdout <-
Data.Text.Lazy.IO.hGetContents stdoutHandle

stderr <-
Data.Text.Lazy.IO.hGetContents stderrHandle

return ( exitCode, Data.Text.Lazy.unpack stdout, Data.Text.Lazy.unpack stderr )
return ( exitCode, Data.Text.unpack stdout, Data.Text.unpack stderr )


-- | See <http://www.fast-downward.org/Doc/SearchEngine>
Expand Down
1 change: 1 addition & 0 deletions fast-downward.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ library
FastDownward.SAS.Version
build-depends:
base ^>= 4.11.1.0 || ^>= 4.12.0.0 || ^>= 4.13.0.0,
async ^>= 2.2.0,
containers ^>= 0.5.11.0 || ^>= 0.6,
mtl ^>= 2.2.2,
process ^>= 1.6.3.0,
Expand Down