Improve tart ip error message (#464)

Resolves #460
cirruslabs · Apr 5, 2023 · 261c180 · 261c180
1 parent 92a4b31
commit 261c180
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/Sources/tart/Commands/IP.swift b/Sources/tart/Commands/IP.swift
@@ -34,9 +34,16 @@ struct IP: AsyncParsableCommand {
     let vmConfig = try VMConfig.init(fromURL: vmDir.configURL)
     let vmMACAddress = MACAddress(fromString: vmConfig.macAddress.string)!
 
-    guard let ip = try await IP.resolveIP(vmMACAddress, resolutionStrategy: resolver, secondsToWait: wait) else {
+    if try !vmDir.running() {
       throw RuntimeError.NoIPAddressFound("no IP address found, is your VM running?")
     }
+
+    guard let ip = try await IP.resolveIP(vmMACAddress, resolutionStrategy: resolver, secondsToWait: wait) else {
+      if (vmConfig.os == .linux && resolver == .arp) {
+        throw RuntimeError.NoIPAddressFound("no IP address found, not all Linux distributions are compatible with ARP resolver")
+      }
+      throw RuntimeError.NoIPAddressFound("no IP address found")
+    }
     print(ip)
   }