stream list alternative #632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it work with the generalized interface, instead of removing only the matching streams and then merging both lists, we remove & add every stream. the old stream is then deallocated and replaced by the newly produced one
custom implementations need to have it available
removes code duplication as well
Beside some small API rename the main difference is that the list implementation is not responsible for deallocating streams. Calling srtp_stream_list_dealloc() on a list that is not empty results in an error. This also changes the default implementation to be a double linked list making removing items faster.
pabuhler
force-pushed
the
stream-list-alt
branch
from
dd78ed2
to
914cb55
Compare
This does it in a cross platform manor.
pabuhler
force-pushed
the
stream-list-alt
branch
from
fdb311b
to
7057f25
Compare
|
relevant changes have been added to #612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative / modification to #612 .
This PR is just for preliminary review, will merge in to #612 if ok.