Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson.build: implement mbedtls support #660

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

iameli
Copy link
Contributor

@iameli iameli commented Dec 5, 2023

This was pretty easy; just porting over mbedtls support that was already added from #512. Now it works with Meson too!

@pabuhler
Copy link
Member

pabuhler commented Dec 5, 2023

@iameli I have no problem with merging these changes, although I do not know much about meson build. Since we moved to github actions for CI meson builds are no longer run regularly. Would you be interested in adding a git hub action for this ?

@iameli
Copy link
Contributor Author

iameli commented Dec 6, 2023

@pabuhler Done! Added a test that mirrors the CMake test — you can see it running successfully for a3c1688 over on my fork here https://github.com/iameli/srtp-ci-test/actions/runs/7108414189

@pabuhler pabuhler merged commit 52e2dbe into cisco:main Dec 6, 2023
33 checks passed
@pabuhler
Copy link
Member

pabuhler commented Dec 6, 2023

@iameli awesome, I have merged this now. In general I dont think we will block merging changes when a meson build fails, but at least we will now know something needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants