add test for ROC mіsmatch #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
force-pushed
the
roc-mismatch-test
branch
2 times, most recently
from
18da4a4
to
8b4f99f
Compare
illustrating the reason why one should carefully pick the initial sequence number low enough to avoid a rollover. See https://webrtc-review.googlesource.com/c/src/+/358360
fippo
force-pushed
the
roc-mismatch-test
branch
from
8b4f99f
to
ba6a14f
Compare
|
Quite interesting that not everything fails... it fails when using OpenSSL but not in "normal" / builtin mode?! Avoided by modifying the test slightly, see second commit. |
|
@fippo Hi, I was curious why it failed with openssl, in the end it was not so exciting. When built with openssl the test uses the GCM cipher which does the decryption & authentication at the same time so it does not fail until it is complete. |
pabuhler
approved these changes
Nov 13, 2024
|
ah, that makes sense, thanks for figuring that out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
illustrating the reason why one should carefully pick the initial sequence number low enough to avoid a rollover.
See
https://webrtc-review.googlesource.com/c/src/+/358360