Conversation
suhasHere
reviewed
May 20, 2025
| #include <sframe/vector.h> | ||
|
|
||
| namespace sframe { | ||
| namespace SFRAME_NAMESPACE { |
Contributor
There was a problem hiding this comment.
should we include #include <namespace.h> ?
Contributor
Author
There was a problem hiding this comment.
We get it via vector.h. (That's why it passes CI)
suhasHere
approved these changes
May 20, 2025
Contributor
suhasHere
left a comment
suhasHere
left a comment
There was a problem hiding this comment.
one question, otherwise lGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the same strategy as MLSpp, adds an optional suffix to the C++ namespace so that multiple versions can be supported in the same binary.