Show component work types in component list items #1479
Conversation
chiaberry
added
the
Type: Enhancement
chiaberry
requested review from
frankhereford,
mateoclarke,
johnclary,
mddilley,
tillyw and
roseeichelmann
moped-editor/src/views/projects/projectView/ProjectComponents/ComponentListItem.js
Outdated
Show resolved
Hide resolved
moped-editor/src/views/projects/projectView/ProjectComponents/ComponentListItem.js
Outdated
Show resolved
Hide resolved
| @@ -107,6 +121,18 @@ export default function ComponentListItem({ | |||
| /> | |||
| </ListItem> | |||
| )} | |||
| <ListItem className={classes.workTypeGroup}> | |||
There was a problem hiding this comment.
Small detail, but this class is now a duplicate of the existing nested one.
moped-editor/src/views/projects/projectView/ProjectComponents/ComponentListItem.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I tested on the deploy preview, and it looks great. I love chips!
One minor detail is that clicking related-project components now causes them to expand ever so slightly:
See john's ironweed project (edited) for example.
|
@johnclary ah because those are components that were either migrated or added before we had the requirement to include a work type @mddilley should I conditionally show the ListItem if there is a component work type? Since its required, i assumed it would always show up, but theres probably a number of components with no type |
|
@chiaberry Yes, I think that we should conditionally render like we do for the description below it. Thanks for catching that @johnclary! 🙏 |
Associated issues
cityofaustin/atd-data-tech#19560
Testing
URL to test:
https://deploy-preview-1479--atd-moped-main.netlify.app/moped/projects/2049?tab=map&project_component_id=2686
Steps to test:
Expand components and see the work type in a gray chip
Ship list