try out citysm/to-millis

package.json

@@ -75,6 +75,7 @@
     "@cityssm/fa-glow": "^0.1.0",
     "@cityssm/mssql-multi-pool": "^4.0.0",
     "@cityssm/simple-fa5-checkbox": "^0.2.1",
+    "@cityssm/to-millis": "^0.1.0",
     "@types/activedirectory2": "^1.2.6",
     "@types/better-sqlite3": "^7.6.11",
     "@types/compression": "^1.7.5",

test/1_serverCypress.js

@@ -2,13 +2,15 @@
 import assert from 'node:assert';
 import { exec } from 'node:child_process';
 import http from 'node:http';
+import { minutesToMillis } from '@cityssm/to-millis';
 import { app } from '../app.js';
 import { portNumber } from './_globals.js';
 function runCypress(browser, done) {
     let cypressCommand = `cypress run --config-file cypress.config.js --browser ${browser}`;
     if ((process.env.CYPRESS_RECORD_KEY ?? '') !== '') {
         cypressCommand += ` --tag "${browser},${process.version}" --record`;
     }
+    // eslint-disable-next-line security/detect-child-process, sonarjs/os-command
     const childProcess = exec(cypressCommand);
     childProcess.stdout?.on('data', (data) => {
         console.log(data);
@@ -44,9 +46,9 @@ describe('lot-occupancy-system', () => {
     describe('Cypress tests', () => {
         it('Should run Cypress tests in Chrome', (done) => {
             runCypress('chrome', done);
-        }).timeout(30 * 60 * 60 * 1000);
+        }).timeout(minutesToMillis(30));
         it('Should run Cypress tests in Firefox', (done) => {
             runCypress('firefox', done);
-        }).timeout(30 * 60 * 60 * 1000);
+        }).timeout(minutesToMillis(30));
     });
 });

test/1_serverCypress.ts

@@ -4,6 +4,8 @@ import assert from 'node:assert'
 import { exec } from 'node:child_process'
 import http from 'node:http'
 
+import { minutesToMillis } from '@cityssm/to-millis'
+
 import { app } from '../app.js'
 
 import { portNumber } from './_globals.js'
@@ -15,6 +17,7 @@ function runCypress(browser: 'chrome' | 'firefox', done: () => void): void {
     cypressCommand += ` --tag "${browser},${process.version}" --record`
   }
 
+  // eslint-disable-next-line security/detect-child-process, sonarjs/os-command
   const childProcess = exec(cypressCommand)
 
   childProcess.stdout?.on('data', (data) => {
@@ -59,10 +62,10 @@ describe('lot-occupancy-system', () => {
   describe('Cypress tests', () => {
     it('Should run Cypress tests in Chrome', (done) => {
       runCypress('chrome', done)
-    }).timeout(30 * 60 * 60 * 1000)
+    }).timeout(minutesToMillis(30))
 
     it('Should run Cypress tests in Firefox', (done) => {
       runCypress('firefox', done)
-    }).timeout(30 * 60 * 60 * 1000)
+    }).timeout(minutesToMillis(30))
   })
 })