Add proper warnings for windows

cjappl · Dec 23, 2024 · 06868d9 · 06868d9
1 parent 4de22d3
commit 06868d9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -34,7 +34,7 @@ jobs:
         cmake --version
 
     - name: Configure CMake
-      run: cmake -B build -DRTLOG_USE_FMTLIB=${{ matrix.use_fmtlib }} -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DRTLOG_FULL_WARNINGS=ON -DRTLOG_BUILD_TESTS=ON -DRTLOG_BUILD_EXAMPLES=ON
+      run: cmake -B build -DRTLOG_USE_FMTLIB=${{ matrix.use_fmtlib }} -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DRTLOG_FULL_WARNINGS=ON -DRTLOG_BUILD_TESTS=ON -DRTLOG_BUILD_EXAMPLES=ON -j 2 
 
     - name: Build
       run: cmake --build build --config ${{ env.BUILD_TYPE }}

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -102,9 +102,17 @@ target_compile_definitions(rtlog
         $<$<CONFIG:Release>:NDEBUG>
 )
 
+set(RTLOG_ALL_WARNINGS)
+
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+  set(RTLOG_ALL_WARNINGS "-Wall;-Werror;-Wformat;-Wextra;-Wformat-security;-Wno-unused-function")
+elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+  set(RTLOG_ALL_WARNINGS "/W4;/WX")
+endif()
+
 target_compile_options(rtlog 
     INTERFACE 
-        $<$<BOOL:${RTLOG_FULL_WARNINGS}>:-Wall -Werror -Wformat -Wextra -Wformat-security -Wno-unused-function>
+        $<$<BOOL:${RTLOG_FULL_WARNINGS}>:${RTLOG_ALL_WARNINGS}>
         $<$<BOOL:${RTLOG_USE_RTSAN}>:-fsanitize=realtime>
 )