Clean Datastore Tables Job #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added config option `clean_datastore_tables`. - Added job to delete datastore tables from unsupported formats.
ThrawnCA
requested changes
Nov 8, 2023
ThrawnCA
reviewed
Nov 8, 2023
- Used `get_action` from toolkit instead of ckanapi dependency. - Reworked some code to make it more gooder. - Removed `url_changed` check.
ThrawnCA
requested changes
Nov 9, 2023
- Better logging. - Added `asbool` for `datastore_active` checks.
- Added falsy check for `url_type`.
ThrawnCA
reviewed
Nov 13, 2023
- Removed `lower` call in logging. - Fixed falsy check on `url_type`.
|
@ThrawnCA |
ThrawnCA
approved these changes
Nov 15, 2023
|
@JVickery-TBS Conflicts need to be resolved after merging #198 |
|
@ThrawnCA conflicts resolved here |
ThrawnCA
reviewed
Jan 29, 2024
- Fixed syntax from flake8.
|
@ThrawnCA flake8 should be good now! qld-gov-au#67 (review) <- am I just going to try and get these automated tests written today. And will shove them in this PR as well |
- Added new test for should remove unsupported resources from datastore.
- Fixed mock module path.
- Fixed fixture's `SubRequest` attribute.
- Finalized parameters and fixtures for new test method.
|
@ThrawnCA new tests are now passing as expected |
duttonw
approved these changes
Feb 1, 2024
ThrawnCA
approved these changes
Feb 1, 2024
- Brought in Thrawn's code to make test method and fixture way less complicated.
# Conflicts: # ckanext/xloader/plugin.py ### RESOLVED.
|
@ThrawnCA brought in ur test changes, thanks that looks a lot better and makes way way more sense haha. Also merged master into this one to resolve conflicts |
duttonw
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(jobs): added job to delete datastore tables;
clean_datastore_tables.This adds the possible feature (controlled by config option) to delete datastore tables for unsupported formats. This is useful in the case that a user updates a Resource to no longer be a datastore resource, but the tables remain. So this helps keep the size of the datastore database down a bit