PY2 & PY3 String/Binary Fixes #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added binary type support and mapping. - Added new config option for strict type guessing. - Minor fixes for python2 types and classes. - Minor fix for failed type guessing.
ThrawnCA
reviewed
Jan 16, 2024
ThrawnCA
reviewed
Jan 16, 2024
| @@ -210,5 +214,7 @@ def type_guess(rows, types=TYPES, strict=False): | |||
| # element in case of a tie | |||
| # See: http://stackoverflow.com/a/6783101/214950 | |||
| guesses_tuples = [(t, guess[t]) for t in types if t in guess] | |||
| if not guesses_tuples: | |||
There was a problem hiding this comment.
How does this handle files with only a header and no data rows?
There was a problem hiding this comment.
@ThrawnCA can you add a test for a header only upload please.
There was a problem hiding this comment.
@duttonw I can't; the pull request doesn't originate from our repo.
- Added to config declaration description.
ThrawnCA
approved these changes
Jan 29, 2024
|
@JVickery-TBS Merge conflict needs to be resolved. |
|
@ThrawnCA fixed conflicts now |
ThrawnCA
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(misc): fixed binary/str types between py2 and py3;