Fix incorrect handling of double quotes in stringify function.

ckeditor · Oct 28, 2024 · 3993705 · 3993705
1 parent f7b3710
commit 3993705
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/components/utils.js b/src/components/utils.js
@@ -68,7 +68,7 @@ export function truncateString( string, length ) {
 // Retain the JSON.stringify() formatting instead of fixing 100 tests across the project :)
 function stringifySingleToDoubleQuotesReplacer( value, indent, stringify ) {
 	if ( typeof value === 'string' ) {
-		return `"${ value.replace( '\'', '"' ) }"`;
+		return `"${ value.replaceAll( '\'', '\\"' ) }"`;
 	}
 
 	return stringify( value );

diff --git a/tests/inspector/components/utils.js b/tests/inspector/components/utils.js
@@ -21,6 +21,10 @@ describe( 'Utils', () => {
 			expect( stringify( () => 'foo' ) ).to.equal( 'function() {…}' );
 		} );
 
+		it( 'serializes quotes properly', () => {
+			expect( stringify( '\'foo\'' ) ).to.equal( '"\\"foo\\""' );
+		} );
+
 		it( 'stringifies values (no quotes around text)', () => {
 			expect( stringify( undefined ) ).to.equal( 'undefined' );
 			expect( stringify( true ) ).to.equal( 'true' );