Added validator for SVGs #17753
Merged
Added validator for SVGs #17753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
reviewed
Jan 15, 2025
|
As we discussed internally, could we extend an existing SVG validator ( |
pomek
reviewed
Jan 17, 2025
pomek
reviewed
Jan 17, 2025
| @@ -28,6 +30,7 @@ module.exports = { | |||
| }, | |||
| { name: 'removeTitle' }, | |||
| { name: 'removeComments' }, | |||
| { name: 'removeMetadata' } | |||
| { name: 'removeMetadata' }, | |||
| svgoViewBoxPlugin | |||
There was a problem hiding this comment.
It works as expected.
However, it turns out that the commercial repository has not executed this validator.
Fortunately, icons will land in a single repository soon so that we can deal with it.
There was a problem hiding this comment.
I'm not sure how to reproduce this issue, could you provide reproduction steps?
pomek
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Added CI validator for editor SVG icons.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.