Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve emoji's docs. #17968

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

Improve emoji's docs. #17968

wants to merge 2 commits into from

Conversation

Witoso
Copy link
Member

@Witoso Witoso commented Feb 20, 2025

Suggested merge commit message (convention)

Docs: Improve emoji's docs.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@Witoso Witoso mentioned this pull request Feb 20, 2025
@@ -270,8 +270,10 @@ export default class EmojiRepository extends Plugin {
}

/**
* By default, the Emoji plugin fetches the emoji repository from CKEditor 5 CDN. To avoid this,
* you can use the {@link module:emoji/emojiconfig~EmojiConfig#definitionsUrl `emoji.definitionsUrl`}
* It was detected that your installation uses a commercial self-hosted license key,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pomek is this factually correct?

@Witoso Witoso requested review from pomek and godai78 February 20, 2025 17:07
@godai78
Copy link
Contributor

godai78 commented Feb 21, 2025

This is peculiar, I already reviewed this, but there is no trace of my changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants