Fix/delay first messages

[PP-Contrib]

Summary by CodeRabbit

• New Features

  • Improved message delay handling for better precision in managing message timings.

• Bug Fixes

  • Enhanced validation checks for destination phone numbers to prevent errors in delay application.

[coderabbitai]

Walkthrough

The changes in the pull request focus on the delayFunc logic within the src/jobs/webhooker.ts file. The previous implementation has been modified to utilize two maps, dUntil and dVerified, instead of a single delays map. This allows for improved tracking of message delays based on timestamps and verification status. The updated logic checks for valid destination phones, calculates delays, and manages message sending more effectively.

Changes

File	Change Summary
src/jobs/webhooker.ts	Refactored delayFunc to use dUntil and dVerified maps for managing message delays based on timestamps instead of a single delays map. Improved logic for checking delays and verifying message sending.

Poem

In the meadow where bunnies play,
Delays now dance in a smarter way.
With timestamps bright, the messages flow,
No more confusion, just watch them go!
Hops of joy, in the code we trust,
For every delay, there's a reason robust! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)

src/jobs/webhooker.ts (1)

26-26: Redundant use of Math.floor with Date.now()

The Date.now() function returns an integer representing the number of milliseconds since the epoch. Applying Math.floor is unnecessary since Date.now() already returns an integer.

You can simplify the code by removing Math.floor.

Apply this diff:

-      const epochMS: number = Math.floor(Date.now());
+      const epochMS: number = Date.now();

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1121f99 and a470506.

📒 Files selected for processing (1)

• src/jobs/webhooker.ts (2 hunks)

🧰 Additional context used

🪛 Biome

src/jobs/webhooker.ts

[error] 8-8: Don't use 'String' as a type.

Use lowercase primitives for consistency.
Safe fix: Use 'string' instead

(lint/complexity/noBannedTypes)

---

[error] 9-9: Don't use 'String' as a type.

Use lowercase primitives for consistency.
Safe fix: Use 'string' instead

(lint/complexity/noBannedTypes)

🔇 Additional comments (2)

src/jobs/webhooker.ts (2)

35-35: Possible negative delay in thisMessageDelay calculation

When calculating thisMessageDelay using nextMessageTime - epochMS, there is a possibility that thisMessageDelay becomes negative if nextMessageTime is less than epochMS. Although the subsequent if condition checks for thisMessageDelay > 0, it's good practice to ensure that delay values are not negative.

Please verify that nextMessageTime is always greater than or equal to epochMS, or adjust the logic to handle negative delays appropriately.

---

Line range hint 13-43: Overall logic and implementation look good

The updated delayFunc implementation enhances the delay handling mechanism effectively. The use of maps to track dUntil and dVerified improves control over message delays based on timestamps.