Ensure storage_ip_rules regexall only matches /31 and /32, but leaves /30 alone since it is valid #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Based on https://learn.microsoft.com/en-us/azure/storage/common/storage-network-security?tabs=azure-portal#restrictions-for-ip-network-rules and my testing, /30 CIDRs should be allowed and are configurable as storage account firewall rules.
Type of change
Changes proposed in this pull request
regexall("/3.", cidr)
toregexall("/3(1|2)", cidr)
to ensure /30 CIDRs are passed through correctly.If I have a data service tag resource as follows:
And I try configuring this module as follows:
It will fail to apply the /30 CIDRs from Azure service tags to the storage account. For example, 20.140.152.52/30 will be changed to 20.140.152.52 and this means 20.140.152.53, 20.140.152.54, 20.140.152.55 will be blocked when they should be allowed.
@claranet/fr-azure-reviewers