Skip to content

Support 9.10 on Windows, add to README #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 26, 2025
Merged

Support 9.10 on Windows, add to README #2939

merged 5 commits into from
Apr 26, 2025

Conversation

DigitalBrains1
Copy link
Member

@DigitalBrains1 DigitalBrains1 commented Apr 18, 2025

On Linux, Clash has been working on GHC 9.10 for a while, both master and 1.8. This PR adds support for Windows, tests macOS in CI, and adds these facts to our README.

All versions of Stackage run in CI are bumped to their latest minors. This allowed simplifying LTS's 22 and 23 (GHC 9.6 and 9.8).

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

@martijnbastiaan
Copy link
Member

@DigitalBrains1 I think we can just remove the Win32 dependency bounds. They're only used in in the clash-ghc/src-bin-*, which we inherit from GHC. Same story for unix.

@DigitalBrains1
Copy link
Member Author

@DigitalBrains1 I think we can just remove the Win32 dependency bounds. They're only used in in the clash-ghc/src-bin-*, which we inherit from GHC. Same story for unix.

As discussed, we copy from the ghc-bin Cabal package, and this is not a transitive dependency of us. So we deemed it safer to not remove the bounds and just bump them.

@DigitalBrains1 DigitalBrains1 changed the title Test 9.10 on macOS, add to README Support 9.10 on Windows, add to README Apr 25, 2025
This dependency is something inherited from the `ghc-bin` Cabal package,
as we vendor code from that package. The 9.10 version of `ghc-bin`
likewise increases this upper bound. It is needed for building GHC 9.10
on Windows.
@DigitalBrains1 DigitalBrains1 force-pushed the ci-stack-9.10 branch 2 times, most recently from 1d6f49d to 5498fdd Compare April 26, 2025 11:20
@DigitalBrains1 DigitalBrains1 disabled auto-merge April 26, 2025 12:21
LTS's 22 and 23 (GHC 9.6 and 9.8) were bumped to their latest minors,
allowing simplification of the configuration.

LTS 21 (GHC 9.4) is bumped to the last minor that used GHC 9.4.7, since
9.4.8 is slow.
The next commit adds a fourth footnote. Depending on the font, the
superscript numerals for 1-3 render differently than for other numerals
(with 0 possibly rendering in yet another way). By using `<sup>`, we get
consistent rendering for all numbers (and we can add punctuation).

As long as we're making things ugly with the `<sup>` markup, we replace
the emoji-style glyphs with character references. The large glyphs break
many editors, making editing nearly impossible.

This commit does not change the contents, just the way it is written in
source-form.
And add a footnote that Clash starts extremely slowly under Windows with
basically all modern GHC's (possibly #2684 although it might be yet
another bug).
@DigitalBrains1 DigitalBrains1 merged commit 76ed2dd into master Apr 26, 2025
14 checks passed
@DigitalBrains1 DigitalBrains1 deleted the ci-stack-9.10 branch April 26, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants