Skip to content

[fix] additionalComposers 없을 때 빈 배열로 반환 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k3vin7 merged 1 commit into from
Feb 18, 2026
Merged

[fix] additionalComposers 없을 때 빈 배열로 반환 #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/com/daramg/server/post/dto/PostResponseDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,12 @@ public static ComposerSummary from(Composer composer) {

private static List<ComposerSummary> extractAdditionalComposers(Post post) {
if (post instanceof CurationPost curationPost
&& curationPost.getAdditionalComposers() != null
&& !curationPost.getAdditionalComposers().isEmpty()) {
&& curationPost.getAdditionalComposers() != null) {
Copy link

@gemini-code-assist gemini-code-assist bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

curationPost.getAdditionalComposers().isEmpty() 조건이 제거되었습니다. 이제 additionalComposers 리스트가 null이 아니라면, 비어있는 리스트일지라도 스트림 처리를 통해 ComposerSummary 리스트로 변환됩니다. 이는 additionalComposers가 비어있을 때도 null 대신 빈 리스트를 반환하여 API 응답의 일관성을 유지하는 데 기여합니다.

return curationPost.getAdditionalComposers().stream()
.map(ComposerSummary::from)
.toList();
}
return null;
return List.of();
Copy link

@gemini-code-assist gemini-code-assist bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

additionalComposers가 존재하지 않거나 CurationPost 타입이 아닌 경우 null 대신 List.of()를 사용하여 불변의 빈 리스트를 반환하도록 변경되었습니다. 이는 클라이언트 코드에서 NullPointerException을 방지하고, 컬렉션 필드에 대해 항상 빈 컬렉션을 기대할 수 있도록 하여 API 사용성을 크게 향상시킵니다.

}

private static PostType getPostType(Post post) {
Expand Down
Loading