Sync with current Cookiecutter template #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claui
commented
Jul 24, 2023
|
|
||
| # In VS Code, this allows developers to manually specify | ||
| # inferrable types so the distracting inline hints go away | ||
| "@typescript-eslint/no-inferrable-types": 0 | ||
|
|
||
| "@typescript-eslint/no-shadow": 1 |
claui
commented
Jul 24, 2023
| no-tabs: 2 | ||
| no-template-curly-in-string: 1 | ||
| no-throw-literal: 2 | ||
| no-trailing-spaces: 1 | ||
| no-undefined: 1 | ||
| no-unexpected-multiline: 1 | ||
| no-unreachable: 1 |
There was a problem hiding this comment.
Is this really part of recommended-type-checked or stylistic-type-checked?
claui
commented
Jul 24, 2023
Comment on lines
+26
to
+28
| /* eslint-disable-next-line | ||
| @typescript-eslint/prefer-nullish-coalescing | ||
| -- falsy is what we want here because of the empty string */ |
There was a problem hiding this comment.
Note to self: I’m going to need those three lines often enough that this might warrant a snippet.
claui
commented
Jul 24, 2023
Comment on lines
+3
to
+8
| export function hello(name: string = "world") { | ||
| if (!name) { | ||
| throw new ValueError("Name cannot be empty.") | ||
| } | ||
| return `Hello, ${name}!`; | ||
| } |
There was a problem hiding this comment.
Replace boilerplate with actual logic.
claui
commented
Jul 24, 2023
Comment on lines
+3
to
+13
| describe("the hello function", () => { | ||
| it("returns a default value", () => { | ||
| expect(hello()) | ||
| .toBe("Hello, world!"); | ||
| }); | ||
|
|
||
| it("greets the author", () => { | ||
| expect(hello("Claudia Pellegrino")) | ||
| .toBe("Hello, Claudia Pellegrino!") | ||
| }); | ||
| }); |
This is useful e.g. for act [1] if using the medium-sized image. Taken from user @francis-switcho’s comment on actions/setup-node. [2] [1]: https://github.com/nektos/act#default-runners-are-intentionally-incomplete [2]: actions/setup-node#182 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.