add optional verification jobs after deploys #108
Conversation
elrayle
force-pushed
the
elr/verify-health
branch
4 times, most recently
from
6f40677 to
7a0d890
Compare
|
This is ready for review. NOTE: A pause is required after deploy completes to allow the system to restart before trying to verify. Not sure it needs to be 5 minutes, but that resulted in a correct validation every time. Without the pause, validation would give a false negative. @qtomlinson Is there ever a second URL to test the EU deploys? I'm wondering if only one validation is needed even if the deploy goes to US and EU. |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Pause for 5 minutes | ||
| run: sleep 300 # Sleep for 300 seconds (5 minutes) |
There was a problem hiding this comment.
This will slow deploys, but I guess we have to live with it for now.
Will be interesting to see if we get timeouts once we go live. If not we may be able to reduce?
| uses: actions/checkout@v4.1.1 | ||
| with: | ||
| repository: 'clearlydefined/operations' | ||
| ref: 'elr/verify-health' |
There was a problem hiding this comment.
Need to change this to the new version before we merging
| @@ -44,10 +44,18 @@ on: | |||
| description: 'postfix to apply to the base name for the primary deploy site (e.g. -prod, -dev)' | |||
| required: true | |||
| type: string | |||
| primary-verification-url: | |||
There was a problem hiding this comment.
Great this is an input as it's going to be different for each app
| run ./scripts/app-workflows/validate-deploy.sh "" "v2.999.0" "1234567890ABCDEF" | ||
| test_value 1 "$status" | ||
| test_value "Error: Invalid JSON string" "${lines[0]}" | ||
| } |
There was a problem hiding this comment.
Great to be thorough with the tests
| uses: actions/checkout@v4.1.1 | ||
| with: | ||
| repository: 'clearlydefined/operations' | ||
| ref: 'elr/verify-health' |
There was a problem hiding this comment.
Need to change before merging
It takes time for the deploy to complete and the health endpoint to reflect the new version.
elrayle
force-pushed
the
elr/verify-health
branch
from
88d6c75 to
0304e1b
Compare
Description
Add verification after deploy. The verification is optional for backward compatibility.
The verification-url is expected to be the app's health endpoint which should produce output in the format...
Follow on steps