Prevent kwargs override on replace #93
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In
scrapy'sRequestclass, the following function is defined -Since,
SeleniumRequestinherits fromRequest, when.replace()is called upon aSelemiunRequestobject, it defers to its super class. And as we can see in the snippet above, a newRequestis constructed using only a select few attributes. These attributes do not includeSeleniumRequest's additional ones such aswait_timeandwait_until. Thus, after a replace call, these attributes are set toNonewhich can lead to all sorts of errors and unexpected behavior.This PR fixes that issue.