fix(clerk-js): Reduce retries for /tokens on 5xx errors
#5106
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fea2b19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anagstef
changed the title
/tokens on 500 errors/tokens on 5xx errors
octoper
approved these changes
Feb 13, 2025
brkalow
reviewed
Feb 13, 2025
| @@ -85,7 +85,8 @@ export class Session extends BaseResource implements SessionResource { | |||
|
|
|||
| getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => { | |||
| return runWithExponentialBackOff(() => this._getToken(options), { | |||
| shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4, | |||
| shouldRetry: (error: unknown, currentIteration: number) => | |||
There was a problem hiding this comment.
Do we really not want to retry on 5xx at all? Traditionally retrying on 5xx is common practice in the case of intermittent errors, but I do see the risk with potentially making the underlying problem worse.
|
Closing this in favor of another solution we are already working on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When requesting a token from FAPI on
/tokens, we retry 4 times if the response is NOT a 4xx error.We want to also stop retrying on 5xx errors.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change