Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-expo): Make publishableKey prop type optional #5399

Merged

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Mar 19, 2025

Description

The publishableKey prop in the Expo <ClerkProvider> component has always been optional (we look for the EXPO_PUBLIC_CLERK_PUBLISHABLE_KEY env var), but now the types reflect this behavior correctly.

Clerk already handles it if no EXPO_PUBLIC_CLERK_PUBLISHABLE_KEY env var is defined:

Screenshot 2025-03-19 at 11 41 27 AM

Resolves ECO-517

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: 128e528

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 11:53pm

@clerk clerk deleted a comment from clerk-cookie Mar 19, 2025
@wobsoriano
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @wobsoriano - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.0.12-snapshot.v20250319181830
@clerk/astro 2.4.1-snapshot.v20250319181830
@clerk/backend 1.25.4-snapshot.v20250319181830
@clerk/clerk-expo 2.9.1-snapshot.v20250319181830
@clerk/express 1.3.55-snapshot.v20250319181830
@clerk/fastify 2.1.28-snapshot.v20250319181830
@clerk/nextjs 6.12.7-snapshot.v20250319181830
@clerk/nuxt 1.4.2-snapshot.v20250319181830
@clerk/react-router 1.1.7-snapshot.v20250319181830
@clerk/remix 4.5.7-snapshot.v20250319181830
@clerk/testing 1.4.29-snapshot.v20250319181830

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/agent-toolkit@0.0.12-snapshot.v20250319181830 --save-exact

@clerk/astro

npm i @clerk/astro@2.4.1-snapshot.v20250319181830 --save-exact

@clerk/backend

npm i @clerk/backend@1.25.4-snapshot.v20250319181830 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.9.1-snapshot.v20250319181830 --save-exact

@clerk/express

npm i @clerk/express@1.3.55-snapshot.v20250319181830 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.28-snapshot.v20250319181830 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.12.7-snapshot.v20250319181830 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.4.2-snapshot.v20250319181830 --save-exact

@clerk/react-router

npm i @clerk/react-router@1.1.7-snapshot.v20250319181830 --save-exact

@clerk/remix

npm i @clerk/remix@4.5.7-snapshot.v20250319181830 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.29-snapshot.v20250319181830 --save-exact

@wobsoriano wobsoriano changed the title chore(clerk-expo): Make publishableKey prop optional chore(clerk-expo): Make publishableKey prop type optional Mar 19, 2025
@wobsoriano wobsoriano merged commit 457ac5a into main Mar 20, 2025
30 checks passed
@wobsoriano wobsoriano deleted the rob/eco-517-make-publishablekey-prop-in-the-expo-sdk-optional branch March 20, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants