Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13 lauch process without context or input #19

Merged
merged 17 commits into from
Dec 17, 2024
Merged

13 lauch process without context or input #19

merged 17 commits into from
Dec 17, 2024

Conversation

tonongregory
Copy link
Collaborator

@tonongregory tonongregory commented Dec 16, 2024 •
edited by njoubert-cleverage
Loading

From #13

Now with 2 new options you can manage the behavior on UI Run Process action (Rocket icon)

By default there is no confirmation modal or form to set input && context

Modal confirmation

clever_age_process:
    configurations:
        process:
                ui:
                    input_context_launcher_form: false
                    run_confirmation_modal: true

Form to set input && context

clever_age_process:
    configurations:
        process:
                ui:
                    input_context_launcher_form: true

clever-age-gtonon and others added 15 commits December 12, 2024 16:52
@clever-age-gtonon
#13 ability to add modal confirmation or nothing instead of launch fr…
e8a4c26 
…om of process run ui.
@clever-age-gtonon
#13 ability to add modal confirmation or nothing instead of launch fr…
85f3145 
…om of process run ui. Update doc
@clever-age-gtonon
#13 ability to add modal confirmation or nothing instead of launch fr…
c9df400 
…om of process run ui.

Twig cs fixer
@clever-age-gtonon
#14 Quality. Phpstan remove - '#type has no value type specified in i…
1ee039b 
…terable type#'

                                    - '#has parameter .* with no value type specified in iterable type#'
                                    - '#has no value type specified in iterable type array#'
                                    - '#configureOptions\(\) has no return type specified.#'
                                    - '#configure\(\) has no return type specified#'
                                    - '#process\(\) has no return type specified#'
                                    - '#should return Iterator but returns Traversable#'
                                    - '#Negated boolean expression is always false#'
@clever-age-gtonon
#14 Quality. Phpstan remove missingType.generics
ccce788
@clever-age-gtonon
#14 Quality. Phpstan 7
1173eee
@clever-age-gtonon
#14 Quality. Phpstan 8
fecf2a2
@clever-age-gtonon
#14 Quality. PhpCs
85cf872
@clever-age-gtonon
#14 Quality. Phpstan use phpstan type to prevent duplicate definitions.
e996d47
@clever-age-gtonon
#14 Quality. Phpstan use phpstan type to prevent duplicate definitions.
1911fbf
@clever-age-gtonon
#13 ability to add modal confirmation or nothing instead of launch fr…
b1433dc 
…om of process run ui.
@clever-age-gtonon
#13 ability to add modal confirmation or nothing instead of launch fr…
65b2003 
…om of process run ui.

PhpStan
@tonongregory
Merge branch 'prepare-release' into 13_lauch_process_without_context_…
5507185 
…or_input
@clever-age-gtonon
#13 ability to add modal confirmation or nothing instead of launch fr…
ad6d10a 
…om of process run ui.

Quality
@clever-age-gtonon
#13 ability to add modal confirmation or nothing instead of launch fr…
dd2e099 
…om of process run ui.

Quality
xaviermarchegay
xaviermarchegay reviewed Dec 16, 2024
View reviewed changes
docs/index.md Outdated

| Options | Values | UI behaviour |
|----------------------------------|----------------|:---------:|
| input_context_launcher_form<br>run_confirmation_modal | false<br>false | Run process without any confirmation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clever-age-gtonon il faudrait mettre les valeurs par défaut sur chaque option.

@tonongregory tonongregory merged commit b781189 into prepare-release Dec 17, 2024
10 checks passed
@njoubert-cleverage njoubert-cleverage added this to the v2.0 milestone Dec 17, 2024
@njoubert-cleverage njoubert-cleverage deleted the 13_lauch_process_without_context_or_input branch December 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xaviermarchegay xaviermarchegay xaviermarchegay left review comments

Assignees

@xaviermarchegay xaviermarchegay

@tonongregory tonongregory

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tonongregory @xaviermarchegay @njoubert-cleverage @clever-age-gtonon