Setup a Build using kodo #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranakan19
requested review from
Shraddhak22,
sbose78,
jaideepr97,
DhanashriPalodkar,
gaganhegde and
ishitasequeira
sbose78
changed the title
|
Have you tried deploying the built image? |
|
Because of a different PR merged by me, there are conflicts in your PR, please resolve them and push again. |
sbose78
reviewed
Jun 22, 2020
Yes, did now, was succesfull. |
sbose78
reviewed
Jun 22, 2020
jaideepr97
reviewed
Jun 23, 2020
jaideepr97
reviewed
Jun 23, 2020
pkg/kodo/cmd/build_test.go
Outdated
Comment on lines
15
to
44
| func getBuildConfig() buildv1api.BuildConfig { | ||
| return buildv1api.BuildConfig{ | ||
| TypeMeta: metav1.TypeMeta{ | ||
| Kind: "BuildConfig", | ||
| APIVersion: "build.openshift.io/v1", | ||
| }, | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "my-app-docker-build", | ||
| }, | ||
| Spec: buildv1api.BuildConfigSpec{ | ||
| CommonSpec: buildv1api.CommonSpec{ | ||
| Source: buildv1api.BuildSource{ | ||
| Type: buildv1api.BuildSourceType("Git"), | ||
| Git: &buildv1api.GitBuildSource{ | ||
| URI: "https://github.com/openshift/ruby-hello-world.git", | ||
| }, | ||
| }, | ||
| Strategy: buildv1api.BuildStrategy{ | ||
| Type: buildv1api.BuildStrategyType("Docker"), | ||
| }, | ||
| Output: buildv1api.BuildOutput{ | ||
| To: &corev1.ObjectReference{ | ||
| Kind: "ImageStreamTag", | ||
| Name: "my-ruby-image:latest", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think a new function is required for this
I think best practice would be for the test cases to be completely isolated and not have any dependence on external functions
There was a problem hiding this comment.
I'm not sure i understand what you mean by external function. I just followed the way we wrote test cases in the session with gagan.
gaganhegde
reviewed
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
What
Supports Building from source with the following command:
kodo build --source=https://github.com/my/appAssumptions
Working Command
Acceptance Criteria
ScreenShots
ImageStreamTag after Build: