Skip to content

Commit

Permalink
fix a grievous thinko
Browse files Browse the repository at this point in the history
  • Loading branch information
nate smith committed Nov 4, 2021
1 parent 81a1272 commit ed1af1e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,14 @@ To test out a release, you can push a prerelease tag like `v2.0.0-pre0`. This wi

If you aren't using Go, you'll need to provide your own script for compiling your extension and configure this action to use `build_script_override`:

This script must produce executables in a `dist` directory all named with a suffix in the format: `platform-architecture-tag`. For example: `my-extension_windows-arm64-v1.0.0`.
This script must produce executables in a `dist` directory all named with a suffix in the format: `platform-architecture`. For example: `my-extension_v1.0.0_windows-arm64`. Front matter in the filename is ignored by `gh`; only the suffix is matched.

For examples of platform/architecture names, see [this list](https://github.com/cli/cli/blob/trunk/pkg/cmd/extension/manager.go#L650).

Your build script will receive the tag to compile against as its first argument (`$1`).

```yaml
- uses: cli/gh-extension-precompile@latest
- uses: cli/gh-extension-precompile@v1
with:
build_script_override: "script/build.sh"
```
Expand Down Expand Up @@ -85,7 +87,7 @@ jobs:
with:
gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
passphrase: ${{ secrets.GPG_PASSPHRASE }}
- uses: cli/gh-extension-precompile@latest
- uses: cli/gh-extension-precompile@v1
with:
gpg_fingerprint: ${{ steps.import_gpg.outputs.fingerprint }}
```
Expand Down
2 changes: 1 addition & 1 deletion build_and_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ else
for p in $platforms; do
goos=$(echo $p | sed 's/-.*//')
goarch=$(echo $p | sed 's/.*-//')
GOOS=${goos} GOARCH=${goarch} go build -o "dist/${goos}-${goarch}-${tag}"
GOOS=${goos} GOARCH=${goarch} go build -o "dist/${goos}-${goarch}"
done
fi

Expand Down

0 comments on commit ed1af1e

Please sign in to comment.