generated from spatie/package-skeleton-laravel
-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(docblocks): Mitigate issue in ide-helper docblock parsing
The generation code has some issues with imported class names in docblocks. It does not resolve those properly and thus leads to incorrect annotations. This was mitigated by transforming all current macro annotations to use the fully qualified class names See barryvdh/laravel-ide-helper#953 Before this PR: ```php /** * * * @param array|string|\MagellanBaseExpression $groups * @return static * @see \Clickbar\Magellan\Database\Builder\BuilderMacros::stGroupBy() * @static */ public static function stGroupBy(...$groups) { return \Illuminate\Database\Query\Builder::stGroupBy(...$groups); } ``` After: ```php /** * * * @param array|string|\Clickbar\Magellan\Database\MagellanExpressions\MagellanBaseExpression $groups * @return static * @see \Clickbar\Magellan\Database\Builder\BuilderMacros::stGroupBy() * @static */ public static function stGroupBy(...$groups) { return \Illuminate\Database\Query\Builder::stGroupBy(...$groups); } ```
- Loading branch information
Showing
2 changed files
with
18 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters