[2.x] Use cast instead of trait #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be conformant with laravel style
We can use new GeometryCast instead, but still need to consider if we need to differentiate between geometry and geography.
Added ST_asGeojson Composer fix
…lan into caster-everywhere
The schema was never added to the ST functions on the first level. This is usually no problem, because people use the public schema anyway. Though for correctness and to properly support changing the schema we fixed this.
When using numeric values for the SRID in functions like `ST_Transform`, the query will throw an error that it cannot parse the SRID projection. This seems to be caused by the PDO driver, which internally always converts parameters to strings. See https://stackoverflow.com/questions/66625661/cannot-bind-value-as-int-with-pdo-pgsql-driver We now append a `::int` cast to numeric SRID parameters, so they work as expected again. For Closures and Expressions, the developer needs to take care of this. We added a note to make them aware of this behavior.
saibotk
changed the title
studnitz
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several breaking changes.
We mainly switched from using a trait to a more native Laravel approach of using a
GeometryCast.This simplifies many things and is easier to use.
Breaking Changes
HasPostgisColumnstrait and$postgisColumnsproperty have been removed.GeometryWKBCasthas been removed.Additions
GeometryCastto handle geometry casting, replacing theGeometryWKBCast.Removals
magellan:update-postgis-columnscommand has been removed.magellan.eloquentandmagellan.model_directoriesconfigurations have been removed.