Snowflake (patch) prevent engine crash (#379)

* Snowflake (path) prevent engine crash

* Refactor SnowflakeDB to handle asynchronous query execution and improve error handling

* update snowflake to enable async queries

src/appmixer/snowflake/bundle.json

@@ -1,6 +1,6 @@
 {
     "name": "appmixer.snowflake",
-    "version": "1.1.12",
+    "version": "1.1.13",
     "changelog": {
         "1.0.0": [
             "Initial version"
@@ -46,6 +46,9 @@
         ],
         "1.1.12": [
             "Update snowflake-sdk dependency to v1.11.0."
+        ],
+        "1.1.13": [
+            "Fixed an issue when invalid query could cause the engine to crash."
         ]
     }
 }

src/appmixer/snowflake/common.js

@@ -1,4 +1,3 @@
-// 'use strict';
 const snowflake = require('snowflake-sdk');
 const { promisify } = require('util');
 
@@ -12,23 +11,31 @@ class SnowflakeDB {
         await promisify(connection.connect).bind(connection)();
         return connection;
     }
-    async runQuery(context, sql) {
-
-        const connection = await this.getConnection(context);
-        const executedQuery = connection.execute({
-            sqlText: sql
+    async getRows(auth, statement) {
+
+        const connection = await this.getConnection(auth);
+        const promise = await new Promise((resolve, reject) => {
+            connection.execute({
+                sqlText: statement.sqlText,
+                asyncExec: true,
+                complete: async function(err, stmt, rows) {
+                    let queryId = stmt.getQueryId();
+                    try {
+                        const results = await connection.getResultsFromQueryId({ queryId });
+                        resolve(results);
+                    } catch (error) {
+                        // We can't throw Snoflake error directly, because it will terminate the node process.
+                        reject(error.message);
+                    }
+                }
+            });
         });
-        return executedQuery;
-    }
-    async getRows(context, statement) {
 
-        const connection = await this.getConnection(context);
-        const executedStatement = connection.execute(statement);
-        return executedStatement.streamRows();
+        return promise.streamRows();
     }
-    async collectRows(context, statement) {
+    async collectRows(auth, statement) {
 
-        const rowStream = await this.getRows(context, statement);
+        const rowStream = await this.getRows(auth, statement);
         const rows = [];
         for await (const row of rowStream) {
             rows.push(row);

src/appmixer/snowflake/package.json

@@ -3,6 +3,6 @@
   "version": "0.0.1",
   "dependencies": {
     "csv-stringify": "6.2.3",
-    "snowflake-sdk": "1.11.0"
+    "snowflake-sdk": "2.0.2"
   }
 }