Skip to content

Commit

Permalink
Merge branch 'release/0.3.45' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
erikvw committed May 24, 2023
2 parents 3c0839c + 4f2b1b2 commit 3c3cdce
Show file tree
Hide file tree
Showing 18 changed files with 10 additions and 29 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.10', '3.11']
django-version: ['4.1', 'dev']

django-version: ['4.1', '4.2', 'dev']
exclude:
- python-version: '3.10'
django-version: 'dev'
services:
mysql:
image: mysql:latest
Expand Down
7 changes: 1 addition & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,8 @@ repos:
- id: debug-statements
- id: detect-private-key

- repo: https://github.com/rstcheck/rstcheck
rev: v6.1.2
hooks:
- id: rstcheck

- repo: https://github.com/adrienverge/yamllint
rev: v1.30.0
rev: v1.31.0
hooks:
- id: yamllint
args:
Expand Down
1 change: 0 additions & 1 deletion VERSION

This file was deleted.

1 change: 0 additions & 1 deletion edc_consent/field_mixins/citizen_fields_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@


class CitizenFieldsMixin(models.Model):

citizen = models.CharField(
verbose_name="Is the participant a Botswana citizen? ",
max_length=3,
Expand Down
2 changes: 0 additions & 2 deletions edc_consent/field_mixins/personal_fields_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@


class BaseFieldsMixin(models.Model):

initials = EncryptedCharField(
validators=[
RegexValidator(
Expand Down Expand Up @@ -67,7 +66,6 @@ class Meta:


class PersonalFieldsMixin(CryptoMixin, BaseFieldsMixin, models.Model):

first_name = FirstnameField(
null=True,
blank=False,
Expand Down
1 change: 0 additions & 1 deletion edc_consent/field_mixins/review_fields_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@


class ReviewFieldsMixin(models.Model):

consent_reviewed = models.CharField(
verbose_name="I have reviewed the consent with the participant",
max_length=3,
Expand Down
1 change: 0 additions & 1 deletion edc_consent/field_mixins/sample_collection_fields_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@


class SampleCollectionFieldsMixin(models.Model):

may_store_genetic_samples = models.CharField(
verbose_name=(
"Does the participant agree that a portion of "
Expand Down
1 change: 0 additions & 1 deletion edc_consent/field_mixins/scored_review_fields_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@


class ScoredReviewFieldsMixin(models.Model):

consent_reviewed = models.CharField(
verbose_name="I have reviewed the consent with the client",
max_length=3,
Expand Down
1 change: 0 additions & 1 deletion edc_consent/field_mixins/site_fields_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@


class SiteFieldsMixin(models.Model):

site_code = models.CharField(
verbose_name="Site",
max_length=25,
Expand Down
1 change: 0 additions & 1 deletion edc_consent/field_mixins/vulnerability_fields_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@


class VulnerabilityFieldsMixin(CryptoMixin, models.Model):

is_incarcerated = models.CharField(
verbose_name="Is the participant under involuntary incarceration?",
max_length=3,
Expand Down
1 change: 0 additions & 1 deletion edc_consent/migrations/0001_initial.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@


class Migration(migrations.Migration):

initial = True

dependencies = []
Expand Down
1 change: 0 additions & 1 deletion edc_consent/model_wrappers/consent_model_wrapper_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@


class ConsentModelWrapperMixin(ModelWrapper):

consent_model_wrapper_cls = None

@property
Expand Down
1 change: 0 additions & 1 deletion edc_consent/models/edc_permissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@


class EdcPermissions(EdcPermissionsModelMixin, BaseUuidModel):

# see edc_auth for permissions attached to this model

class Meta(EdcPermissionsModelMixin.Meta):
Expand Down
1 change: 0 additions & 1 deletion edc_consent/requires_consent.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def __init__(
consent_model: Optional[str] = None,
consent_group: Optional[str] = None,
):

self.version = None
self.model = model
self.subject_identifier = subject_identifier
Expand Down
4 changes: 0 additions & 4 deletions edc_consent/tests/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@


class SubjectScreening(models.Model):

screening_identifier = models.CharField(max_length=25, unique=True)

initials = models.CharField(max_length=5, default="TO")
Expand Down Expand Up @@ -105,7 +104,6 @@ class Meta(ConsentModelMixin.Meta):


class SubjectVisit(SiteModelMixin, BaseUuidModel):

subject_identifier = models.CharField(max_length=25)

# appointment = models.OneToOneField(Appointment, on_delete=CASCADE)
Expand All @@ -116,12 +114,10 @@ class SubjectVisit(SiteModelMixin, BaseUuidModel):
class TestModel(
NonUniqueSubjectIdentifierModelMixin, RequiresConsentFieldsModelMixin, BaseUuidModel
):

report_datetime = models.DateTimeField(default=get_utcnow)


class CrfOne(NonUniqueSubjectIdentifierModelMixin, BaseUuidModel):

subject_visit = models.ForeignKey(SubjectVisit, on_delete=PROTECT)

report_datetime = models.DateTimeField(default=get_utcnow)
1 change: 0 additions & 1 deletion edc_consent/tests/tests/test_consent_form.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ class SubjectConsentFormValidator(


class SubjectConsentForm(ConsentModelFormMixin, FormValidatorMixin, forms.ModelForm):

form_validator_cls = SubjectConsentFormValidator

screening_identifier = forms.CharField(
Expand Down
1 change: 0 additions & 1 deletion edc_consent/views/home_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@


class HomeView(EdcViewMixin, NavbarViewMixin, TemplateView):

template_name = f"edc_consent/bootstrap{get_bootstrap_version()}/home.html"
navbar_name = "edc_consent"
navbar_selected_item = "consent"
Expand Down
7 changes: 5 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ exclude_lines = [
legacy_tox_ini = """
[tox]
envlist =
py{310,311}-dj{41,dev},
py{310}-dj{41,42},
py{311}-dj{41,42,dev},
lint
isolated_build = true
Expand All @@ -48,7 +49,8 @@ python =
[gh-actions:env]
DJANGO =
4.1: dj41, lint
4.1: dj41
4.2: dj42, lint
dev: djdev
[testenv]
Expand All @@ -58,6 +60,7 @@ deps =
-r https://raw.githubusercontent.com/clinicedc/edc/develop/requirements.tests/edc.txt
-r https://raw.githubusercontent.com/clinicedc/edc/develop/requirements.tests/third_party_dev.txt
dj41: Django>=4.1,<4.2
dj42: Django>=4.2,<5.0
djdev: https://github.com/django/django/tarball/main
commands =
Expand Down

0 comments on commit 3c3cdce

Please sign in to comment.