Skip to content

Commit

Permalink
fix: docker-run now properly supports interactive (#516)
Browse files Browse the repository at this point in the history
And docker-run docs updated to use new test tasks
  • Loading branch information
lread authored Dec 3, 2022
1 parent 806672d commit 1dfb1de
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion bb.edn
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"docker run -it --rm -v"
(cond-> [(str (fs/cwd) ":/etaoin")
"-w" "/etaoin"]
(when-not (seq *command-line-args*)) (conj "--entrypoint" "/bin/bash")
(not (seq *command-line-args*)) (conj "--entrypoint" "/bin/bash")
:always (conj "etaoin:latest")
:always (concat *command-line-args*)))}
ci-release {:doc "release tasks, use --help for args"
Expand Down
15 changes: 10 additions & 5 deletions doc/02-developer-guide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -142,17 +142,22 @@ bb docker-build
TIP: This will build a docker image with current releases of Chrome, Firefox and their respective WebDrivers.
Rerun the command as necessary.

You can use this image interactively:
You can run a single command and exit:
[source,shell]
----
bb docker-run bb test:bb --suites unit
----

Or use the docker image interactively:
[source,shell]
----
bb docker-run
bb test all
----

Or you can use it to run a single command:
And then at the interactive prompt:
[source,shell]
----
bb docker-run bb test all
bb test:jvm --suites ide --browsers firefox
----

NOTE: `docker-run` plunks you automatically into `/etaoin` which maps to the etaoin project root
Expand All @@ -163,7 +168,7 @@ Feel free to run docker commands directly if that is more your thing.

=== WebDriver Processes

Sometimes WebDriver process might hang around longer than you'd like.
Sometimes WebDriver processes might hang around longer than you'd like.

To list them:
[source,shell]
Expand Down

0 comments on commit 1dfb1de

Please sign in to comment.