ci: fix downloading deps for windows #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `download-deps` bb task creates a basis for each deps.edn alias in-process to efficiently download all deps (work is done in build.clj). Because the `:build` alias also included `deps-deploy` its many deps were brought in. This seems to somehow mess up bringing down conflicting(?) deps for other aliases, at least for Windows. I've separated out `deps-deploy` to `:deploy` from `:build` alias to try to avoid the issue. Also: switched to `clojure.tools.build.api/create-basis`, was using `clojure.tools.deps/create-basis`; no need to use deps ns when build api exposes this fn. Also: was depending on stale `org.clojure/tools.build` maven dep, switched to current `io.github.clojure/tools.build` dep and updated to current version. Closes #252
This should fix GitHub API rate limit errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
download-depsbb task creates a basis for each deps.edn alias in-process to efficiently download all deps (work is done in build.clj).Because the
:buildalias also includeddeps-deployits many deps were brought in. This seems to somehow mess up bringing down conflicting(?) deps for other aliases, at least for Windows.I've separated out
deps-deployto:deployfrom:buildalias to try to avoid the issue.Also: switched to
clojure.tools.build.api/create-basis, was usingclojure.tools.deps/create-basis; no need to use deps ns when build api exposes this fn.Also: was depending on stale
org.clojure/tools.buildmaven dep, switched to currentio.github.clojure/tools.builddep and updated to current version.Closes #252