Adds improvements & new crates to publish-crates.sh
#2173
Merged
+71
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
reviewed
Jan 27, 2025
bfops
reviewed
Jan 27, 2025
bfops
reviewed
Jan 27, 2025
bfops
reviewed
Jan 27, 2025
bfops
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Thank you for doing this! This looks better than what I got from copilot in my spike of making these changes.
That said, I think it needs another quick pass.
Ideally these would also be separate changes since they're logically independent:
- Bump crate versions
- Add new crates to publish script
- Add new functionality to publish script
That said, they're all small and self-contained so I think it's okay to leave these in the same PR this time (as long as you're fine with all of them waiting to merge until all of them are approved).
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
…x-publish' of github.com:clockworklabs/SpacetimeDB into tyler/bump-version-fix-publish
|
Created #2176 to track us investigating the |
bfops
changed the title
publish-crates.sh
|
I moved the version bumps into #2177. |
|
Thank you for making the changes, this LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR modifies
publish-crates.sh:--allow-dirtywhich is forwarded tocrates publishtyler@clockworklabs.ioandzeke@clockworklabs.ioto be an owner on all newly published cratesNOTE! I recommend we investigate https://github.com/crate-ci/cargo-release in the future rather than to improve this script ad infinitum.
API and ABI breaking changes
None
Expected complexity level and risk
1, it can only break this script, but nothing else.
Testing
I have not tested the new improvements to the script since it's quite hard to test without bumping the versions on things. The risk however is very low and I figure we can fix issues as they come.