-
Notifications
You must be signed in to change notification settings - Fork 599
TypeScript: Add confirmed reads config #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I've been digging around for a way to test this, but it seems like additional URL parameters are added only on a "real" connection object, so it would require an e2e test harness. If anyone has a better idea, please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very hyped for this! Just want to ask about confirmedReads
vs synchronousCommit
(i.e. the color of the bikeshed). I'm okay with either, but wanted to ask if it's worth considering the other for the purpose of being closer to Postgres. Presumably for PGWire it will be literally SET synchronous_commit = ON;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks straight-forward enough that I don't think we need to add automated testing in this PR. I would like to make the default be to not specify a value, rather than defaulting to false.
There is a subtle difference, in that Postgres allows to apply That is, from the client's perspective, enabling confirmed reads will affect visibility of transactions made by others (note that this is different from the reducer's perspective). So, re-using the terminology when it's not exactly the same semantics seems like it could cause confusion. |
Description of Changes
Adds a way to configure the DbConnection to use confirmed reads.
Expected complexity level and risk
1
Testing
Still figuring out...