fix: truncate #3261
Merged
fix: truncate #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Sep 23, 2025
Centril
approved these changes
Sep 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
# Description of Changes - `add_columns_to_table` api to handle `AutoMigrateStep::AddColumns` -- Look at doc comment for more Info. depends on: #3261 TODO: handle `AutoMigrateStep::DisconnectAllUsers`. # API and ABI breaking changes N/A. # Expected complexity level and risk 2? Changes are not in hotpath but a bug in migration can corrupt tables. # Testing a test to exercise the API. --------- Signed-off-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Shubham Mishra <shivam828787@gmail.com> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Based on,and to fix mentioned issues on #3215 i.e -
TxData::insertstoo.visit_truncatescan not callschema_for_tablesfor dropped tables as schema info has been deleted fromst_*tables. Hence, added a field inReplayVisitorto cache table names.This PR decouples truncation info from delete entries, since deletion alone can’t reliably tell about truncation without extra mutations later.
Can be reviewed commit wise.
Testing
Testing using "Add columns" PR.