Remove the dependency on git ls-files from cli/build.rs #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We technically don't need to `git ls-files` when getting the CLI templates because when we compile the release builds we work with a clean git clone, thus it's unlikely any untracked files will be created in the templates directory.
drogus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We technically don't need to
git ls-fileswhen getting the CLI templates because when we compile the release builds we work with a clean git clone, thus it's unlikely any untracked files will be created in the templates directory.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing