Disconnect clients when updating RLS rules #3574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
force-pushed
the
mamcx/rls-disconnect-clients
branch
2 times, most recently
from
11c4134 to
4245ae5
Compare
mamcx
force-pushed
the
mamcx/rls-disconnect-clients
branch
from
4245ae5 to
0041eca
Compare
smoketests/tests/auto_migration.py
Outdated
|
|
||
| self.write_module_code(self.MODULE_CODE_UPDATED) | ||
| self.publish_module(self.database_identity, clear=False) | ||
| self.publish_module(self.database_identity, clear=False, break_clients=True) |
Collaborator
There was a problem hiding this comment.
Can you remove the RLS rules from this test now that we have a separate smoke test for them? It's important that publishing the module in this test doesn't break clients.
mamcx
force-pushed
the
mamcx/rls-disconnect-clients
branch
from
0041eca to
8dab9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As title says
API and ABI breaking changes
This is a behavioural change. Before clients incorrectly operate under the old rules.
Expected complexity level and risk
1
Testing
spacetime subscribe