Materialize views for sql http calls #3586
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
commented
Nov 6, 2025
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-query
branch
3 times, most recently
from
0e43a96 to
8168623
Compare
joshua-spacetime
changed the title
last_called timestamp in st_view_sub for sql queries
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-query
branch
2 times, most recently
from
657d86b to
3c5530b
Compare
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-query
branch
from
3c5530b to
eadfc38
Compare
Centril
requested changes
Nov 7, 2025
| use spacetimedb_schema::schema::{Schema, TableSchema}; | ||
| use spacetimedb_vm::relation::RelValue; | ||
| use std::collections::VecDeque; | ||
| use std::collections::{HashSet, VecDeque}; |
Contributor
There was a problem hiding this comment.
This shouldn't use HashSet from libstd.
| @@ -1,10 +1,28 @@ | |||
| use std::sync::Arc; | |||
| use std::{collections::HashSet, sync::Arc}; | |||
Comment on lines
+257
to
+274
| self.visit(&mut |plan| match plan { | ||
| Self::TableScan(scan, _) => { | ||
| if let Some(info) = &scan.schema.view_info { | ||
| views.insert(info.view_id); | ||
| } | ||
| } | ||
| Self::IxScan(scan, _) => { | ||
| if let Some(info) = &scan.schema.view_info { | ||
| views.insert(info.view_id); | ||
| } | ||
| } | ||
| Self::IxJoin(join, _) => { | ||
| if let Some(info) = &join.rhs.view_info { | ||
| views.insert(info.view_id); | ||
| } | ||
| } | ||
| _ => {} | ||
| }); |
Contributor
There was a problem hiding this comment.
Suggested change
| self.visit(&mut |plan| match plan { | |
| Self::TableScan(scan, _) => { | |
| if let Some(info) = &scan.schema.view_info { | |
| views.insert(info.view_id); | |
| } | |
| } | |
| Self::IxScan(scan, _) => { | |
| if let Some(info) = &scan.schema.view_info { | |
| views.insert(info.view_id); | |
| } | |
| } | |
| Self::IxJoin(join, _) => { | |
| if let Some(info) = &join.rhs.view_info { | |
| views.insert(info.view_id); | |
| } | |
| } | |
| _ => {} | |
| }); | |
| self.visit(&mut |plan| { | |
| let view_info = match plan { | |
| Self::TableScan(scan, _) => &scan.schema.view_info, | |
| Self::IxScan(scan, _) => &scan.schema.view_info, | |
| Self::IxJoin(join, _) => &join.rhs.view_info, | |
| _ => return, | |
| }; | |
| if let Some(info) = view_info { | |
| views.insert(info.view_id); | |
| } | |
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Materialize views if necessary for sql queries. Also update the subscriber count and
last_calledtimestamp inst_view_sub.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
TODO