repeat integrationt tests on failure, update sesman test comments

clojure-emacs · Jul 1, 2023 · c39ec5d · c39ec5d
1 parent e0c16a7
commit c39ec5d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -78,4 +78,7 @@ jobs:
 
     - name: Test integration
       run: |
-        eldev -p -dtTC test --test-type integration
+        # The tests occasionally fail on macos&win in what is seems to
+        # be GH connectivity runner issues. We attempt to address this
+        # problem by rerunning the tests more than once.
+        eldev -p -dtTC test --test-type integration || eldev -p -dtTC test --test-type integration
diff --git a/test/cider-tests.el b/test/cider-tests.el
@@ -687,8 +687,9 @@
             (setq endpoint-bef nrepl-endpoint))
 
           (sesman-restart)
-          ;; wait until a new server is brought up, i.e. the port has
-          ;; changed. It will throw if it doesn't.
+          ;; wait until a new server is brought up by continuously checking that
+          ;; the port has changed. If it remains the same, an exception is
+          ;; thrown, causing the test to fail.
           (nrepl-tests-poll-until (when-let ((repl (cider-current-repl)))
                                     (with-current-buffer repl
                                       (setq endpoint-aft nrepl-endpoint)