Pass cider-default-cljs-repl value to server's on-port-callback #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jun 18, 2018
| (cider--jack-in do-prompt | ||
| (lambda (server-buffer) | ||
| (cider-connect-sibling-cljs server-buffer))))) | ||
| (let ((cider-default-cljs-repl cljs-repl-type)) |
There was a problem hiding this comment.
I'm not a big fan of dynamic binding, as it makes the code harder to read. Maybe we should pass this as a param?
There was a problem hiding this comment.
I think we should do it anyhow. cider-connect-siblings-cljs accepts other-repl as first and the only argument. This is useless for interactive use. So I would say we make two argument with the first one being cljs-repl-type (or maybe more generic params) which would ask on C-u for repl type. Then even with dir-local default-cljs-repl set one can spark a different repl type with C-u C-c M-s.
bbatsov
reviewed
Jun 18, 2018
| @@ -944,8 +948,7 @@ Figwheel, etc), unless you've set `cider-default-cljs-repl'. OTHER-REPL | |||
| can also be a server buffer, in which case a new session with a REPL for | |||
| that server is created." | |||
| (interactive (list (cider-current-repl))) | |||
| (let ((cljs-repl-type (or cider-default-cljs-repl | |||
| (cider-select-cljs-repl))) | |||
| (let ((cljs-repl-type (or cider-default-cljs-repl (cider-select-cljs-repl))) | |||
There was a problem hiding this comment.
Or we can obtain this differently here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2336