Fix clojure.core function highlighting on ClojureScript
#3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jul 31, 2023
| @@ -107,7 +107,8 @@ This will be clojure.core or cljs.core depending on the return value of the | |||
| function `cider-repl-type'." | |||
| (when-let* ((repl (cider-current-repl))) | |||
| (with-current-buffer repl | |||
| (cider-resolve--get-in (if (eq cider-repl-type 'cljs) | |||
| (cider-resolve--get-in (if (or (eq cider-repl-type 'cljs) | |||
| (derived-mode-p 'clojurescript-mode)) | |||
There was a problem hiding this comment.
Looking at the code this shouldn't be needed - notice the use of with-current-buffer, which means that will always come from the REPL and you can never really have clojurescript-mode there.
There was a problem hiding this comment.
Good eye. Then it should be a matter of simply updating cider-nrepl.
|
I'll just move the changelog entry to #3379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3385
(Needs a trivial cider-nrepl fix too, but I'm adding this as a changelog anyway. Will be upgraded in the following few days)