Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macos aarch64 java/17 integration testing #3671

Merged
merged 1 commit into from
May 19, 2024

Conversation

ikappaki
Copy link
Contributor

Hi,

could you please review follow patch up to #3669, to add integration testing for java/17 on the apple silicon on @vemv's request.

I've also added the badge for the ci integration tests on the github workflows, which was long overdue.

Thanks

@ikappaki ikappaki force-pushed the maint/macos-latest-java-17 branch from d9176a7 to 73ff577 Compare May 19, 2024 09:12
@bbatsov
Copy link
Member

bbatsov commented May 19, 2024

Seems to me we might be overdoing the platforms (OS + JVM) on which we run the integration tests, as I don't recall much problems historically that they have caught, but I'll merge this regardless. Adding the badge is a good idea. Thanks!

@bbatsov bbatsov merged commit b37a8d5 into clojure-emacs:master May 19, 2024
39 checks passed
@vemv
Copy link
Member

vemv commented May 19, 2024

Thanks, @ikappaki !

Seems to me we might be overdoing the platforms (OS + JVM) on which we run the integration tests, as I don't recall much problems historically that they have caught,

It's a relatively young solution (< 1 year), a good chunk of its value being that we don't unawarely break the underlying feature that introduced those tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants