Skip to content

Conversation

@jNullj
Copy link
Contributor

@jNullj jNullj commented Oct 24, 2025

Follow up for #298 see also #297 (comment)
dependency update to make sure docusaurus-preset-openapi is compatible with react 19 for npm with strict peer dep

work needs to be done for taking care of braking changes as presented in the release notes for v2.0.0
edit, changes seem to do not effect us but we also have to explore breaking changes in dependencies (move to rtk2) as can be found here
edit 2, seems like we should be good.

@netlify
Copy link

netlify bot commented Oct 24, 2025

Deploy Preview for docusaurus-openapi ready!

Name Link
🔨 Latest commit 412ad11
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-openapi/deploys/69234fbff2bd170008825630
😎 Deploy Preview https://deploy-preview-301--docusaurus-openapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jNullj jNullj marked this pull request as ready for review October 24, 2025 15:37
@chris48s
Copy link
Collaborator

Thanks, but this should be updated in the theme package, not the preset plugin.


As this stands, the theme plugin would still be using ^1.7.1
Also this PR does not update the project lockfile
There's info on how to update individual dependencies within packages in #300 (comment)

@jNullj
Copy link
Contributor Author

jNullj commented Oct 25, 2025

I remember a log with preset blocking the npm install for shields, but i might have goofed, let me re-check this.
Regardless i don't mind updating both, couldn't hurt.

regarding the lockfile, i used git add . from inside the preset package path so it was not included, i will fix that once i figure out that missing log or recreate it.

@chris48s
Copy link
Collaborator

Shields only directly depends directly on docusaurus-preset-openapi so you will have hit the error trying to upgrade docusaurus-preset-openapi (which then transitively bumps the other workspace packages)
but docusaurus-preset-openapi doesn't directly consume @reduxjs/toolkit
All of the code that uses that package is under packages/docusaurus-theme-openapi
https://github.com/search?q=repo%3Acloud-annotations%2Fdocusaurus-openapi+%40reduxjs%2Ftoolkit&type=code
and that's where we'll need to deal with any BC breaks

@jNullj
Copy link
Contributor Author

jNullj commented Nov 23, 2025

i tested locally with overrides to see what blocks us, as you suggested i need to update @reduxjs/toolkit at the theme package, but also react-redux needs to be updated to version newer than v9.0.0 to support react 19, as version 7 used here and even 8 seem to support up to react 18.

I will update this PR, but from what i seen at my try at building this, it will probably not work without going over breaking changes, this may take some additional time.

@jNullj jNullj changed the title bump @reduxjs/toolkit to ^2.4.0 bump react-redux & @reduxjs/toolkit for reac19 npm compitability Nov 23, 2025
@jNullj jNullj changed the title bump react-redux & @reduxjs/toolkit for reac19 npm compitability bump react-redux & @reduxjs/toolkit for react 19 npm compitability Nov 23, 2025
@jNullj
Copy link
Contributor Author

jNullj commented Nov 23, 2025

ok, updated both and added fixes for build failures due to breaking changes.
i am not very familiar with react/redux so i hope nothing is missing here.

@jNullj
Copy link
Contributor Author

jNullj commented Nov 23, 2025

@chris48s can you give this another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants