-
Notifications
You must be signed in to change notification settings - Fork 85
bump react-redux & @reduxjs/toolkit for react 19 npm compitability #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docusaurus-openapi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks, but this should be updated in the theme package, not the preset plugin.
As this stands, the theme plugin would still be using ^1.7.1 Also this PR does not update the project lockfile There's info on how to update individual dependencies within packages in #300 (comment) |
|
I remember a log with preset blocking the npm install for shields, but i might have goofed, let me re-check this. regarding the lockfile, i used |
|
Shields only directly depends directly on docusaurus-preset-openapi so you will have hit the error trying to upgrade docusaurus-preset-openapi (which then transitively bumps the other workspace packages) |
|
i tested locally with overrides to see what blocks us, as you suggested i need to update I will update this PR, but from what i seen at my try at building this, it will probably not work without going over breaking changes, this may take some additional time. |
bbfa0e6 to
b9a1860
Compare
|
ok, updated both and added fixes for build failures due to breaking changes. |
|
@chris48s can you give this another look? |
Follow up for #298 see also #297 (comment)
dependency update to make sure docusaurus-preset-openapi is compatible with react 19 for npm with strict peer dep
work needs to be done for taking care of braking changes as presented in the release notes for v2.0.0
edit, changes seem to do not effect us but we also have to explore breaking changes in dependencies (move to rtk2) as can be found here
edit 2, seems like we should be good.