Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ibm: add Disk, GPU information in VMSpec #1402

Closed
wants to merge 1 commit into from
Closed

Ibm: add Disk, GPU information in VMSpec #1402

wants to merge 1 commit into from

Conversation

suahlingo
Copy link
Member

  • Add Disk, GPU information in VMSpec

@powerkimhub powerkimhub self-requested a review December 19, 2024 05:27
powerkimhub
powerkimhub requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@powerkimhub powerkimhub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ish-hcc @suahlingo

  • 하드 코딩 관련 사전에 문의 주신 내용인데, 제가 잘못 답변 드린 것 같습니다.
  • Spec Name에서 값들을 추출하는 로직을 생각하면서, 순간 이 방법을 하드 코딩으로 생각하고
    • 하드코딩으로 하시면 된다고 답변 드렸습니다^^ 죄송합니다.
  • 다음처럼, Name split 및 변환 처리를 고려 부탁 드립니다.
    • 현재 PR은 Spec이 추가 되거나 하면, 대응이 어려운 부분이 있습니다.

image

Makefile Outdated
@@ -2,7 +2,7 @@ VERSION := $(shell git describe --tags --abbrev=8 | sed 's/-g.*//')
COMMIT_SHA := $(shell git rev-parse --short HEAD)
BUILD_TIME := $(shell date)

default: swag
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 변경 부분('swag' 제거)이 의도하신 부분이신지,
  • 개발 환경이 잘못 따라 올라온 것인지 문의 및 확인 부탁 드립니다.

setup.env Outdated
@@ -11,7 +11,7 @@ export CBSPIDER_ROOT=`cd $SCRIPT_DIR && pwd`
#export SERVER_ADDRESS=":3000"

# examples for K8S env
#export SERVER_ADDRESS=":1024"
export SERVER_ADDRESS="192.168.130.44:1024"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 개인 환경으로 변경하신 값이 따라 올라온 것 같습니다.
  • default 설정은 원래 상태로 유지 부탁 드립니다.

@powerkimhub powerkimhub mentioned this pull request Dec 19, 2024
Merged
@suahlingo
Copy link
Member Author

@powerkimhub 확인했습니다! 수정하고 다시 pr하겠습니다.

@suahlingo suahlingo closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerkimhub powerkimhub powerkimhub requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suahlingo @powerkimhub