Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: operate Service #85

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix: operate Service #85

merged 1 commit into from
Nov 12, 2024

Conversation

heedaeshin
Copy link
Contributor

@heedaeshin heedaeshin commented Nov 12, 2024

Please fill out the following sections to describe your pull request.

Summary of Changes

  • Fix: AWS force destroy and public access handling
  • Fix: GCP force destroy and public access handling
  • Note: NCP does not support public access method for DB resources

PR Type

What kind of changes does this PR introduce? (Please check the relevant boxes and select the type.)

  • Add: Add a new feature
  • Fix: Fix a bug
  • Style: Change user UI design (CSS, etc.)
  • Chore: Changes that do not affect the code (typo fixes, tab size changes, variable name changes)
  • Refactor: Code refactoring
  • Docs: Add or modify comments and documentation
  • Test: Add or refactor tests
  • Build: Modify build-related configurations or package managers
  • Rename: Rename files or folders
  • Remove: Delete files or folders

Detailed Description of Changes

Related Issues

Screenshots (if applicable)

PR Checklist

Ensure your PR meets the following requirements:

  • The commit messages follow the Conventional Commits convention.
    • Example: Add: New user login feature, Fix: Payment error bug
  • Tests for the changes have been added or updated.
  • Documentation has been updated accordingly.
  • All necessary changes for code review are included.
  • The build passes successfully.
  • A deployment plan has been established if necessary.

Additional Notes

@heedaeshin heedaeshin merged commit 047a7bd into main Nov 12, 2024
2 checks passed
@heedaeshin heedaeshin deleted the feature/fix-operate-service branch November 13, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant