Fixing CodeQL errors #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnuchalla
force-pushed
the
fix-codeql
branch
2 times, most recently
from
65407ba to
2c729b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 85.41% 82.23% -3.19%
==========================================
Files 6 6
Lines 288 349 +61
==========================================
+ Hits 246 287 +41
- Misses 28 48 +20
Partials 14 14 ☔ View full report in Codecov by Sentry. |
vishnuchalla
force-pushed
the
fix-codeql
branch
3 times, most recently
from
5a68c67 to
722f32f
Compare
Signed-off-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.rmtusnc.csb>
vishnuchalla
force-pushed
the
fix-codeql
branch
from
722f32f to
ba07c4d
Compare
|
Weird thing of the coverage change percentage, don't see how your change did that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Making sure all the CI tests are passing. Minor nit.
Checklist before requesting a review
Testing
Will be verified through CI.