To support tf count along with rosa-burner args #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukrishn
force-pushed
the
merge_tf
branch
2 times, most recently
from
af53152 to
a21c375
Compare
|
This pull request has become stale and will be closed automatically within 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adding a logic to separate TF template creation away from threading logic, that way it lets us create multiple cluster using a single template and thread watches the
rosa logsto know the status of the deployment.Tested it at small scale, we will use this for TF scale runs.
Keeping this as draft until properly tested.
Related Tickets & Documents
Checklist before requesting a review