Skip to content

Commit

Permalink
Merge branch 'main' into ack-current
Browse files Browse the repository at this point in the history
  • Loading branch information
jtaleric authored Dec 18, 2024
2 parents 0395130 + 9be6b3c commit afbef21
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 21 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/builders.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@ name: Builders
on:
workflow_call:
workflow_dispatch:
pull_request_target:
branches:
- master
- main
jobs:
build:
runs-on: ubuntu-latest
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/pylint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,19 @@ name: Pylint
on:
workflow_call:
workflow_dispatch:
pull_request_target:
branches:
- master
- main
jobs:
lint:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.11"]
steps:
- uses: actions/checkout@v3
- name: Check out code
uses: actions/checkout@v4
with:
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha }}
persist-credentials: false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
Expand All @@ -23,7 +24,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pylint
pip install -r requirements.txt
- name: Analysing the code with pylint
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
file-install: false

- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha }}
Expand All @@ -34,7 +34,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pylint
pip install -r requirements.txt
pip install .
Expand Down
10 changes: 1 addition & 9 deletions pkg/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,7 @@ def load_config(config: str, parameters: Dict= None) -> Dict[str, Any]:
return rendered_config

def load_ack(ack: str) -> Dict[str,Any]:
"""Loads ack file
Args:
config (str): path to config file
Returns:
dict: dictionary of the config file
"""

"Loads acknowledgment file content."
logger_instance = SingletonLogger.getLogger("Orion")
try:
with open(ack, "r", encoding="utf-8") as template_file:
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ python-multipart==0.0.9
scikit-learn==1.5.0
scipy==1.12.0
uvicorn==0.28.0
pylint==3.3.2

0 comments on commit afbef21

Please sign in to comment.