Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Refine uuid split #28

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[Trivial] Refine uuid split #28

merged 1 commit into from
Mar 26, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Mar 25, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Trivial bug fix in baseline UUIDs split.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Verified in local in a hacky way.

>>> import re
>>> baseline="uuid1,uuid2, uuid3,uuid4 uuid5 uuid6, uuid7,uuid8,                uuid9"
>>> uuids = re.split(' |,',baseline)
>>> print(uuids)
['uuid1', 'uuid2', '', 'uuid3', 'uuid4', 'uuid5', 'uuid6', '', 'uuid7', 'uuid8', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', 'uuid9']
>>> uuids = [uuid for uuid in re.split(' |,',baseline) if uuid]
>>> print(uuids)
['uuid1', 'uuid2', 'uuid3', 'uuid4', 'uuid5', 'uuid6', 'uuid7', 'uuid8', 'uuid9']
>>> exit()

Signed-off-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.remote.csb>
orion.py Show resolved Hide resolved
@shashank-boyapally
Copy link
Contributor

/lgtm

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtaleric jtaleric merged commit 186fab7 into cloud-bulldozer:main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants