Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng - switch to ruff and update dependencies #71

Merged
merged 4 commits into from
Nov 13, 2024
Merged

releng - switch to ruff and update dependencies #71

merged 4 commits into from
Nov 13, 2024
+137 −710

Conversation

kapilt
Copy link
Contributor

@kapilt kapilt commented May 22, 2024 •
edited
Loading

switch to ruff for lint and format and update dependencies

ajkerrigan
ajkerrigan approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me 👍. I'm curious if ruff covers all the pre-commit checks we're removing (like end of line or debug message stuff). But I'd be +1 either way 😀

@kapilt kapilt merged commit afd968b into cloud-custodian:main Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkerrigan ajkerrigan ajkerrigan approved these changes

@marcoceppi marcoceppi marcoceppi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kapilt @marcoceppi @ajkerrigan